fix: allways allow duplicaiton - #8689
Conversation
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| </template> | ||
| {{ $t('calendar', 'Export') }} | ||
| </ActionLink> | ||
| <ActionButton v-if="!canCreateRecurrenceException && !isReadOnly" @click="duplicateEvent()"> |
There was a problem hiding this comment.
issue: copying events with recurrence doesn't work
It is unexpected input for copyCalendarObjectInstanceIntoEventComponent.
See #8606
[ERROR] calendar: [Vue error]: Error in component event handler: Error: Illegal argument: Event objects has recurrence related property RRULE.
There was a problem hiding this comment.
The reason, I didn't just implemented it in #8606 was, that I didn't know what the expected behavior should be.
Like, should we:
- Copy one occurrence?
- Copy the whole series?
- Copy the occurrence and all future instances?
- Or have some UI for the user to choose?
| {{ $t('calendar', 'Export') }} | ||
| </NcActionLink> | ||
| <NcActionButton v-if="!canCreateRecurrenceException && !isReadOnly && !isNew" @click="duplicateEvent()"> | ||
| <NcActionButton v-if="!isNew" @click="duplicateEvent()"> |
There was a problem hiding this comment.
issue: This now makes the button also available when user is not logged in.
e.g. apps/calendar/embed/... or public links
| {{ $t('calendar', 'Export') }} | ||
| </NcActionLink> | ||
| <NcActionButton v-if="!canCreateRecurrenceException && !isReadOnly && !isNew" @click="duplicateEvent()"> | ||
| <NcActionButton v-if="!isNew" @click="duplicateEvent()"> |
There was a problem hiding this comment.
issue: Doesn't work with shared calendars, because after duplicating the target calendar is still the original calendar and cannot be changed.
Screencast.From.2026-08-06.08-12-50.mp4
|
Found #8421 that implements duplication for read-only events. |
2 participants
Summary