fix: backport author association policy and align checks - #854
Open
joshtrichards wants to merge 2 commits into
Open
fix: backport author association policy and align checks#854joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
Central helper that can be used by both the `issue_comment.created` and `pull_request.closed` handlers. Updates policy from !== NONE to a more explicitly policy. Adjust policy that was previously >non-collaborators despite the old code comment. Assisted-by: Copilot:GPT-5.6 Signed-off-by: Josh <josh.t.richards@gmail.com>
Enforce backport author association policy using new central helper. As a result also uses same new policy. Signed-off-by: Josh <josh.t.richards@gmail.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
1 task
susnux
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns backport authorization across live comment handling and post-merge request scanning.
OWNER,MEMBER,COLLABORATOR, andCONTRIBUTOR.FIRST_TIMER,FIRST_TIME_CONTRIBUTOR,NONE, missing, and unknown associations.githubUtils.tsso both processing paths use the same check.Policy change: replaces the permissive "anything except NONE" check -- including first-time contributors and any future association values that get created -- with an explicit allowlist for repository maintainers, collaborators, and established contributors.
This is a minor policy change in the scheme of things, as it better aligns with the previously documented policy (by the inline comments) + seems rational/reasonable (IMO) + tightens security slightly + is more future proof.
🤖 AI (if applicable)