fix(navigation): fill the active filter icon, outline the rest - #2869
Open
pringelmann wants to merge 2 commits into
Open
fix(navigation): fill the active filter icon, outline the rest#2869pringelmann wants to merge 2 commits into
pringelmann wants to merge 2 commits into
Conversation
pringelmann
commented
Aug 18, 2026
| } | ||
|
|
||
| .app-navigation-entry { | ||
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
artonge
approved these changes
Aug 18, 2026
AndyScherzinger
approved these changes
Aug 18, 2026
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
AndyScherzinger
force-pushed
the
fix/nav-icons-filled-when-active
branch
from
August 18, 2026 10:50
c8ccb78 to
d2fae06
Compare
Member
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2662
The nav icons were a mix of outlined and filled, with nothing tying that to which filter you're on. Each filter id now has both variants from
@mdi, and the icon slot picks one off theNcAppNavigationItemactiveprop:The map has to be here rather than in the backend:
getIcon()returns one URL, and a second state would mean changing public OCP API. Filters not in the map keep their backend URL and stay put when selected. One example is Deck, where we decided to keep the actual app icon as a real solid mark, plus Tasks and anything else third-party.🤖 AI (if applicable)