[stable8] feat(NcDateTimePickerNative): floating label design - #8782
Draft
backportbot[bot] wants to merge 2 commits into
Draft
[stable8] feat(NcDateTimePickerNative): floating label design#8782backportbot[bot] wants to merge 2 commits into
backportbot[bot] wants to merge 2 commits into
Conversation
Reserve 6px block-start margin on the .v-select container so the floated label has room to overshoot the top border, matching the margin-block-start applied to .input-field in NcInputField. This keeps NcSelect and NcInputField visually aligned when used side-by-side in a form row. Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Use `Omit` + `Exclude` so date/time input types are blocked on NcTextField while new non-date types added to NcInputField are inherited automatically. Users should use NcDateTimePickerNative for date/time inputs instead. Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
backportbot
Bot
added
3. to review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable8 #8782 +/- ##
===========================================
- Coverage 47.01% 46.99% -0.03%
===========================================
Files 195 195
Lines 4943 4943
Branches 1274 1274
===========================================
- Hits 2324 2323 -1
Misses 2531 2531
- Partials 88 89 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8768
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.