feat(NcDialog): expose modal container padding as CSS variables - #8767
Draft
skjnldsv wants to merge 1 commit into
Draft
feat(NcDialog): expose modal container padding as CSS variables#8767skjnldsv wants to merge 1 commit into
skjnldsv wants to merge 1 commit into
Conversation
The padding of the modal container around the dialog was hardcoded (4px 0 block, 12px 0 inline). Expose it as --dialog-padding-block and --dialog-padding-inline (defaulting to the current values) so consumers can adjust the dialog padding without overriding internal, scoped selectors. Assisted-by: ClaudeCode:claude-fable-5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8767 +/- ##
==========================================
- Coverage 52.64% 52.61% -0.03%
==========================================
Files 109 109
Lines 3687 3687
Branches 1077 1076 -1
==========================================
- Hits 1941 1940 -1
- Misses 1486 1487 +1
Partials 260 260 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP