Update README for multiple branch support#584
Open
selvamt94 wants to merge 1 commit into
Open
Conversation
Contributor
holyspectral
left a comment
holyspectral
left a comment
There was a problem hiding this comment.
LGTM. Thanks for doing this! I'd change the wording a little bit so it saves us some time moving forward.
Comment on lines
+31
to
+33
| helm charts v2.8.x => will stay with NV v5.5.1 forever. | ||
| helm charts v2.9.10 => NV v5.4.10 | ||
| helm charts v2.10.2 => NV v5.5.2 |
Contributor
There was a problem hiding this comment.
I'd recommend something like below, so we don't have to go back and update them for each release.
Suggested change
| helm charts v2.8.x => will stay with NV v5.5.1 forever. | |
| helm charts v2.9.10 => NV v5.4.10 | |
| helm charts v2.10.2 => NV v5.5.2 | |
| helm charts v2.8.x => will stay with NV v5.5.1 forever. | |
| helm charts v2.9.x => NV v5.4.x | |
| helm charts v2.10.x => NV v5.5.x |
Comment on lines
+30
to
+32
| helm charts v2.8.x => will stay with NV v5.5.1 forever. | ||
| helm charts v2.9.10 => NV v5.4.10 | ||
| helm charts v2.10.2 => NV v5.5.2 |
Contributor
There was a problem hiding this comment.
Suggested change
| helm charts v2.8.x => will stay with NV v5.5.1 forever. | |
| helm charts v2.9.10 => NV v5.4.10 | |
| helm charts v2.10.2 => NV v5.5.2 | |
| helm charts v2.8.x => will stay with NV v5.5.1 forever. | |
| helm charts v2.9.x => NV v5.4.x | |
| helm charts v2.10.x => NV v5.5.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated README mentioning multiple branch
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement