Skip to content

fix: restore dashboard app shell#160

Merged
JustAGhosT merged 1 commit into
mainfrom
agent/fix-dashboard-app-shell
Jul 19, 2026
Merged

fix: restore dashboard app shell#160
JustAGhosT merged 1 commit into
mainfrom
agent/fix-dashboard-app-shell

Conversation

@JustAGhosT

Copy link
Copy Markdown
Collaborator

Summary

  • render the shared header/navigation in authenticated dashboard routes
  • restore readable dashboard metrics/table colors in dark mode by using design tokens
  • add the missing dashboard card wrapper styles used by the page
  • fix stale 404 helper links that pointed at /dashboard/dashboard and /dashboard/* route-group paths

Validation

  • pnpm exec eslint 'app/(dashboard)/layout.tsx' app/not-found.tsx
  • pnpm exec prettier --check 'app/(dashboard)/layout.tsx' app/not-found.tsx styles/dashboard.module.css styles/shared.module.css
  • pnpm run type-check
  • pnpm run build

@JustAGhosT
JustAGhosT merged commit 202b48c into main Jul 19, 2026
7 checks passed
@JustAGhosT
JustAGhosT deleted the agent/fix-dashboard-app-shell branch July 19, 2026 00:28

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2067b2fc0b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

<ErrorBoundary>{children}</ErrorBoundary>
</div>
<>
<Header />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid rendering duplicate headers on Layout pages

On routes covered by this dashboard layout that already render components/layouts/Layout (for example /content-adaptation, /automation, /campaigns, and /series), that component renders its own ScrollingHeader at components/layouts/Layout.tsx:51. Adding Header here means those authenticated pages now show two sticky navigation bars, duplicating the app chrome and reducing usable viewport; either only render this header for pages without the shared Layout wrapper or remove the nested page-level header layout there.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant