Import bootstrapped dev Key Vault policy before apply#85
Merged
Conversation
Terraform Plan (
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd7f17b9a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| resource "azurerm_key_vault_access_policy" "ci_deployers" { | ||
| for_each = var.ci_deployer_object_ids | ||
| for_each = setsubtract(var.ci_deployer_object_ids, [data.azurerm_client_config.current.object_id]) |
There was a problem hiding this comment.
When an existing dev state was applied with the prior configuration, it can contain azurerm_key_vault_access_policy.ci_deployers["d487..."] for the same GitHub Actions principal now represented by deployer. This exclusion makes Terraform plan a destroy for that old address; Key Vault access policies are keyed by object ID, so that destroy deletes the same remote policy imported at deployer, leaving the CI principal without secret access after apply. Move that state address to deployer (or explicitly remove the obsolete state entry without destroying the remote policy) as part of this migration.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
Validation