Skip to content

Remove Docassemble core dependency from install_requires #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nonprofittechy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove Docassemble core dependency from install_requires #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ def find_package_data(
install_requires=[
"requests>=2.31.0",
"pycountry>=22.3.5",
"docassemble.webapp>=1.4.54",
"defusedxml>=0.7.1",

@michaelhofrichter michaelhofrichter May 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal here is correct and well-reasoned. install_requires is what pip uses during package resolution, so keeping docassemble.webapp there was the root cause of the resolver walking into older PyPI releases of the core stack.

One thing to consider: docassemble/LegalServerLink/requirements.txt still lists both docassemble.base>=1.4.54 and docassemble.webapp>=1.4.54. If that file is used in CI or local dev (pip install -r requirements.txt), the same resolver issue could surface there. It looks like a dev/CI file (it also includes mypy and lxml which aren't in install_requires), so it may be intentionally separate — but worth confirming whether it should get the same treatment for consistency.

],
zip_safe=False,
Expand Down