fix(ui): drop the double border on searchable-select form inputs#642
Conversation
The .field input box rule (1px border) also matched .combobox-input, which sits inside .searchable-select — the wrapper that already carries the field's border — so a second, inner frame was drawn. Exclude .combobox-input from the rule (as .date-field already is) so only the wrapper borders the control. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the CSS styling in frontend/src/styles/app.css to exclude .combobox-input from the default .field input styling and focus-visible rules. This change prevents double borders because the wrapper element .searchable-select already handles the border styling. No review comments were provided, and I have no additional feedback to offer.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Searchable-select fields on the settings/sync page (and every other form combobox) drew a double border: the outer
.searchable-selectwrapper carries the field box by design, but the shared.field input { border: 1px }rule also matched the inner.combobox-input, adding a second inner frame.Fix
Exclude
.combobox-inputfrom the.field inputbox rule (base +:focus-visible), mirroring the existing:not(.date-field)exclusion. The input keeps its ownborder: 0; only the wrapper borders the control.Verification
Computed styles on
/ui/settings/sync(dark theme) after the change:.searchable-select→border: 1px solid rgb(60,67,75)(single frame).combobox-input→border: 0px none(no inner frame)Pre-existing since the combobox landed in v6.3.0; the same class of rule needed
:not(.date-field)earlier.