fix(ci): bake build provenance into the profiling image (status page version)#639
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the docker-bake.hcl file to bake build provenance arguments (APP_BUILD_REVISION, APP_BUILD_REF, and APP_BUILD_DATE) into the app-profiling target image. This ensures that the /ui/admin/status page correctly displays the deployed commit, reference, and date when running the profiling image. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
The prod hot-deploy runs the :profiling-<sha> image, but only the `app` (release) bake target set APP_BUILD_REVISION/REF/DATE — `app-profiling` inherited only _common and passed no build args, so the deployed image had them empty and /ui/admin/status showed "unknown". Add the args to app-profiling and pass GIT_REF + BUILD_DATE (not just GIT_SHA) to the profiling build step, so the status page shows the deployed commit, ref and build date. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
CybotTM
force-pushed
the
fix/profiling-build-metadata
branch
from
July 16, 2026 08:05
cdf623a to
7c92dbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prod hot-deploy runs the
:profiling-<sha>image, but only theapp(release) bake target bakedAPP_BUILD_REVISION/REF/DATE.app-profilinginherited only_commonand passed no build args, so the deployed image had them empty and /ui/admin/status showed "unknown" for the version.Fix
docker-bake.hcl: add theargs = { APP_BUILD_REVISION = GIT_SHA, APP_BUILD_REF = GIT_REF, APP_BUILD_DATE = BUILD_DATE }block to theapp-profilingtarget (mirroringapp).docker-publish.yml: passGIT_REF+BUILD_DATEto the profiling build step (it only passedGIT_SHA).Verification
docker buildx bake app-profiling --printresolves the target with the threeAPP_BUILD_*args populated. Dockerfile (profiling stage) + the frontend BuildSection already consume them — after this builds + deploys, the status page shows the deployed commit / ref / date and the up-to-date check.Note: modifies a
.github/workflows/file, so it needs a manual merge (the default token lacks theworkflowsscope).