Skip to content

fix: update otel peerDependencies#7094

Merged
cshio merged 1 commit into
mainfrom
cshio/fix-otel-peer-range
Jun 16, 2026
Merged

fix: update otel peerDependencies#7094
cshio merged 1 commit into
mainfrom
cshio/fix-otel-peer-range

Conversation

@cshio

@cshio cshio commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Related to FRB-2069

The 36.0.0 release (#7093) majored every package, including @netlify/opentelemetry-sdk-setup (2→3). @netlify/build's peerDependencies range stayed ^2.0.0, so npm install fails with ERESOLVE — blocking the release PR's benchmark, formatting, update-lockfile, and lint-title checks.

Widen the range to ^2.0.0 || ^3.0.0 (release-please's node-workspace doesn't auto-bump peerDeps; the union resolves on both main's current 2.x and the release's 3.0.0). Lockfile also picks up the engines.node sync #7054 left stale.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@cshio cshio self-assigned this Jun 16, 2026
@cshio cshio requested a review from a team as a code owner June 16, 2026 18:18
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 38fab483-7407-4e32-b775-393caf1559c1

📥 Commits

Reviewing files that changed from the base of the PR and between 4358aa0 and 0c00aec.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • packages/build/package.json
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • netlify/blueprints (manual)

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Expanded peer dependency compatibility to support additional versions of a build optimization library, enabling better flexibility with newer package versions.

Walkthrough

The peerDependencies field in packages/build/package.json is updated so that @netlify/opentelemetry-sdk-setup accepts ^2.0.0 || ^3.0.0 instead of only ^2.0.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: update otel peerDependencies' directly summarizes the main change in the changeset—updating the opentelemetry peer dependency version range.
Description check ✅ Passed The PR description includes a summary explaining the motivation and problem being solved, though it uses an issue reference (FRB-2069) instead of a full link, and the checklist items are incomplete as is typical for open PRs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cshio/fix-otel-peer-range

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cshio cshio enabled auto-merge (squash) June 16, 2026 18:27
@cshio cshio merged commit 0151b1a into main Jun 16, 2026
30 checks passed
@cshio cshio deleted the cshio/fix-otel-peer-range branch June 16, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants