test: fix tests as recent change was not caught because of .skip condition#6999
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| }) | ||
|
|
||
| describe.skipIf(lt(denoVersion, '2.4.3'))( | ||
| describe.skipIf(lt(denoVersion, '2.4.2'))( |
There was a problem hiding this comment.
We run tests in CI with 2.4.2
build/.github/workflows/workflow.yml
Line 57 in d578f7c
This was bumped in #6684 (without bumping used version in github action or our "minimal" supported deno version) but it was only relevant to deno bundle specific issue which we don't use anymore.
As we don't need 2.4.3 for current method I opted to keep our minimal deno version and version in CI and instead walk back this skip condition
| expect(entries).toContain('___netlify-edge-functions.json') | ||
| expect(entries).toContain('deno.json') | ||
| expect(entries).toContain('func1.ts') | ||
| expect(entries).toContain('./___netlify-edge-functions.json') |
There was a problem hiding this comment.
The need to change existing tests was introduced in #6990 but not caught because CI did not run them.
The tarball bundles still work fine, just paths are slightly different
| @@ -1,4 +1,4 @@ | |||
| import { getMessage } from './@file_prefixed_with_the_at_symbol.ts' | |||
| import { getMessage } from '../../@file_prefixed_with_the_at_symbol.ts' | |||
There was a problem hiding this comment.
the location of @file_prefixed_with_the_at_symbol.ts was treated as function and failing because there is no default export (request handler), so just moved this file out of netlify/edge-functions directory
pieh
changed the title
2 participants
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #<replace_with_issue_number>
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)