[messaging] feat: fix multiple error message handler - #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes error handling in HandlerMiddleware when multiple handlers are registered for the same routing key and one of them fails asynchronously.
Previously, the single-handler path wrapped errors correctly, but the multi-handler path assumed every rejected result from Promise.allSettled() had the shape { handler, error }. That was only true for synchronous throws caught inside the
mapper. For normal async rejections, result.reason was the raw Error, which caused follow-up handling to read undefined and break error logging/aggregation.
What Changed
Type of change
Breaking change
Checklist