Skip to content

Reap child when capture_output errors in CommandRunner::run #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Finesssee merged 1 commit into from
Aug 29, 2026
Merged

Reap child when capture_output errors in CommandRunner::run #401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion rust/src/host/command_runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,13 @@ impl CommandRunner {
Self::send_initial_input(&mut child, input, options.initial_delay, deadline);

// Capture output
let (output, stderr, timed_out) = self.capture_output(&mut child, options, deadline)?;
let (output, stderr, timed_out) = match self.capture_output(&mut child, options, deadline) {
Ok(captured) => captured,
Err(e) => {
let _exit_code = Self::finish_child(&mut child);
return Err(e);
}
};

let exit_code = Self::finish_child(&mut child);

Expand Down
Loading