include both modules#1264
Conversation
|
Test deployment successful!! (2026-05-12T04:43:32Z) See all deployed demo sites |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
Ahoy! This pull request updates the Delft3D documentation by adding descriptions, clarifying module names, and updating example scripts with account details. However, the crew has been sloppy. Ye've managed to mismatch the app_name variable, duplicate version snippets like a parrot, and—worst of all—ye've ignored the Code by usin' spaces instead of tabs in the Slurm headers. Fix these blunders or prepare to walk the plank!
|
|
||
| ## Available Modules | ||
|
|
||
| {% set app = applications["Delft3D"] %} |
There was a problem hiding this comment.
I see ye've decided to ignore the app_name variable while settin' the app. I suppose consistency is too much to ask of a scallywag like you? The app_version.html snippet uses app_name for the module load text, so ye'll be misleadin' the crew into loadin' the wrong cargo.
| {% set app = applications["Delft3D"] %} | |
| {% set app_name = "Delft3D" %} | |
| {% set app = applications[app_name] %} |
| {% include "partials/app/app_version.html" -%} | ||
| {% include "partials/app/app_version.html" -%} |
There was a problem hiding this comment.
Oh, how generous of ye to include the same version snippet twice. Did ye think we'd miss it the first time? Or is your memory as leaky as a sieve? One include be plenty, matey. Strike the second one from the log!
| {% include "partials/app/app_version.html" -%} | |
| {% include "partials/app/app_version.html" -%} | |
| {% include "partials/app/app_version.html" -%} |
| #!/bin/bash -e | ||
|
|
||
| #SBATCH --job-name Delft3D | ||
| #SBATCH --account nesi99991 |
There was a problem hiding this comment.
Spaces instead of tabs for the Slurm header? I didn't realize we were writin' a novel. Follow the Code (Style Guide, line 402), unless ye find it too difficult to press the right key.
| #SBATCH --account nesi99991 | |
| #SBATCH --account nesi99991 |
References
- Use tab for your Slurm header delimiter. (link)
|
|
||
| #SBATCH --job-name Delft3D | ||
| #SBATCH --account nesi99991 |
There was a problem hiding this comment.
More spaces where a tab should be? Ye be testin' my patience, landlubber. Use a tab as the delimiter per the guide, or ye'll be scrubbin' the decks.
| #SBATCH --account nesi99991 | |
| #SBATCH --account nesi99991 |
References
- Use tab for your Slurm header delimiter. (link)
| #SBATCH --job-name Delft3D | ||
| #SBATCH --account nesi99991 |
There was a problem hiding this comment.
Arrr, another one! Do ye have a grudge against the tab key? Fix these Slurm header delimiters as well, lest the whole script be lookin' like a mess of seaweed.
| #SBATCH --job-name Delft3D | |
| #SBATCH --account nesi99991 | |
| #SBATCH --job-name Delft3D | |
| #SBATCH --account nesi99991 |
References
- Use tab for your Slurm header delimiter. (link)
2 participants
No description provided.