This repository was archived by the owner on Oct 4, 2024. It is now read-only.
Add new argument for generating keys using secp256k1 algorithm - #922
Open
artur-torosian-4irelabs wants to merge 1 commit into
Open
Add new argument for generating keys using secp256k1 algorithm#922artur-torosian-4irelabs wants to merge 1 commit into
artur-torosian-4irelabs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has some changes in key generating command, it's expanding it with a new argument for keygen algorithm. Right now we can use only 2 algos: secp256k1 and ed25519 which is set as a default algo.
IMPORTANT: For enabling this logic you will need near-api-js module version with changes that enables ability to generate keys using secp256k1.