fix: prevent messages from taking too long to be sent - #902
Open
ChaoticTempest wants to merge 8 commits into
Open
fix: prevent messages from taking too long to be sent#902ChaoticTempest wants to merge 8 commits into
ChaoticTempest wants to merge 8 commits into
Conversation
added 2 commits
October 18, 2024 17:46
…x/prevent-msg-taking-too-long
ailisp
reviewed
Oct 18, 2024
ailisp
reviewed
Oct 18, 2024
ailisp
previously approved these changes
Oct 18, 2024
ailisp
left a comment
ailisp
left a comment
Contributor
There was a problem hiding this comment.
Nice improvement by concurrently sending messages!
ppca
previously approved these changes
Oct 18, 2024
ppca
left a comment
ppca
left a comment
Contributor
There was a problem hiding this comment.
LGTM except the tracing comment.
volovyks
previously approved these changes
Oct 21, 2024
added 3 commits
October 24, 2024 12:10
…x/prevent-msg-taking-too-long
…x/prevent-msg-taking-too-long
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
messages will occasionally take over 1s to send, which can stall the node from doing work. This PR makes all the
send_encryptedbe ran concurrently such that the node don't wait until the previoussend_encryptedgets completed. I've seen the message sending portion go from 1-2s max to 300ms max so this should be a good improvement with no breaking changes