bench: cycle distinct prefilled blocks to remove per-append fill#2
Closed
nclack wants to merge 1 commit into
Closed
bench: cycle distinct prefilled blocks to remove per-append fill#2nclack wants to merge 1 commit into
nclack wants to merge 1 commit into
Conversation
Owner
Author
|
Superseded by acquire-project#159 (PR retargeted to upstream). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes acquire-project#150.
Streaming benches spent ~half their wall time generating their own input via the per-append
fill()inpump_data/pump_data_interleaved, which understated library throughput ~2x and let the fill thread contend with the library for host memory bandwidth (medfmt/zstd regressed ~18% purely from contention).Changes:
PUMP_CYCLE_BLOCK_COUNT), filled once with staggered offsets so contents differ block-to-block but keep the same value distribution — realistic compression ratios with zero per-append fill cost. Applied to both single-stream and the two-stream interleaved pump.--busy-producerkeeps the original regenerate-every-append behavior as a host-bandwidth stress variant.--prefill(single identical block) retained for back-compat / writer-only ceiling.Data gen time(seconds / % of wall) so harness cost is visible instead of folded into throughput.--dtype(always bpe=2); it now usesdtype_bpe(dtype), matching the two-stream path.A/B to validate: default vs
--busy-producerthroughput (expect ~2x gap; medfmt/zstd contention regression gone under default), and matching compressed bytes between default and busy modes (vs inflated ratio under--prefill).