You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Additional regex to support the specification of optional dependencies/extras for a package. Current behavior will match the extra name within the '[]' rather than the package + specified extra.
Note that this still allows mistakes like abc[DEF HIJ, which will return three package names. However, short of implementing the full grammar, I'm not sure of a way around this. Also, the intent of the regex is to prevent malicious strings, not mistakes. Curious if there are other thoughts before merging this though.
Note that this still allows mistakes like abc[DEF HIJ, which will return three package names. However, short of implementing the full grammar, I'm not sure of a way around this. Also, the intent of the regex is to prevent malicious strings, not mistakes. Curious if there are other thoughts before merging this though.
That is a good point. I also don't immediately see a way around this without even further extending the regex to check for when whitespace is and isn't allowed in the grammar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional regex to support the specification of optional dependencies/extras for a package. Current behavior will match the extra name within the '[]' rather than the package + specified extra.