fix: lazy init for sensors tab and Wayland tray popup#6
Open
iswad-lab wants to merge 6 commits into
Open
Conversation
…artup) fix: Wayland-compatible popup for tray widget (Qt.Popup -> Window flags)
feat: remember window geometry between sessions feat: desktop entries and app icon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
1. Lazy init for Sensors tab
setup_ui()was called inTemperatureSourcesWidget.__init__(), blockingnbfc-qtstartup for ~3s whilenbfc complete-sensorspolls for NVIDIA sensors. Moved tostart()— called only when user clicks the "Sensors" tab.2. Wayland-compatible tray popup
Qt.Popupuses Wayland'sxdg_popupprotocol which requires a parent that has received focus, causing warnings or crashes. Replaced withQt.WindowType.Window | Qt.WindowType.FramelessWindowHint | Qt.WindowType.WindowStaysOnTopHint+focusOutEventto hide on click outside (popup-like behavior).