Skip to content

Change optional skip claude target#1574

Merged
scottf merged 2 commits into
mainfrom
claude-target
May 12, 2026
Merged

Change optional skip claude target#1574
scottf merged 2 commits into
mainfrom
claude-target

Conversation

@scottf
Copy link
Copy Markdown
Contributor

@scottf scottf commented May 11, 2026

No description provided.

@scottf
Copy link
Copy Markdown
Contributor Author

scottf commented May 11, 2026

@claude review

@synadia-claude-reviewer
Copy link
Copy Markdown

synadia-claude-reviewer Bot commented May 11, 2026

Claude finished @scottf's task in 52s —— View job


Code Review

  • Gather context and read changed files
  • Analyze the diff
  • Post review feedback

Summary

The change updates .github/workflows/claude.yml to switch the PR trigger from pull_requestpull_request_target, and adds ready_for_review to the trigger types. The if: condition guard is updated in lockstep to reference the new event name.


Analysis

pull_requestpull_request_target

This is a meaningful security/access distinction:

pull_request pull_request_target
Runs in context of PR branch Base branch
Secrets available for fork PRs No Yes
Executes code from Fork Base repo

Switching to pull_request_target is the right call here because the workflow needs access to secrets (CLAUDE_OAUTH_TOKEN, CLAUDE_GH_APP_PRIVATE_KEY) to function on fork PRs. This also aligns with checkout_mode: base being passed to the reusable workflow — the action checks out the base branch's trusted code rather than the fork's code, which is the standard mitigation for the elevated-privilege risk of pull_request_target. The existing permissions block (contents: read, actions: read) further limits the blast radius. This looks correct and safe.

Adding ready_for_review

Good addition. Previously, draft PRs converted to ready-for-review would not trigger Claude. Now they will, which is the expected behavior.

if: condition

Updated correctly from pull_requestpull_request_target to match the renamed event. The logic is sound: skip the Claude job only when the triggering event is a pull_request_target event and [skip claude] is in the PR body.


Verdict

LGTM. The change is consistent and correct — both the trigger and the condition guard are updated together, the security posture with pull_request_target + checkout_mode: base is appropriate, and ready_for_review is a sensible addition.

No issues found.

@scottf scottf merged commit a8627b6 into main May 12, 2026
5 checks passed
@scottf scottf deleted the claude-target branch May 12, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant