Skip to content

feat: multi-device sync via Automerge CRDT + sync-server integration#92

Draft
nashaofu with Copilot wants to merge 3 commits into
masterfrom
copilot/add-authentication-api
Draft

feat: multi-device sync via Automerge CRDT + sync-server integration#92
nashaofu with Copilot wants to merge 3 commits into
masterfrom
copilot/add-authentication-api

Conversation

Copilot AI commented Apr 27, 2026

Copy link
Copy Markdown
Contributor
  • Analyze sync_manager.rs and commands/sync.rs
  • sync_manager.rs: Replace explicit drop() with block scopes in set_server_url / set_tokens / pull_changes_from_server / push_changes_to_server / apply_remote_changes
  • sync_manager.rs: push_changes_to_server — return error when 401 token-refresh fails (was silently succeeding)
  • sync_manager.rs: apply_remote_changes — filter valid changes with filter_map, then apply in one batch call
  • sync_manager.rs: Log errors in set_server_url and set_tokens instead of silently discarding
  • sync.rs: start_device_auth — remove 3 unnecessary intermediate String variables
  • sync.rs: trigger_sync_pull — replace manual for-loop with iterator filter_map chain + log base64 decode failures

Copilot AI and others added 2 commits April 27, 2026 00:24
… validation, status propagation

Agent-Logs-Url: https://github.com/nashaofu/shell360/sessions/11fc8e90-c12b-4056-af6c-976b777cd2ca

Co-authored-by: nashaofu <19303058+nashaofu@users.noreply.github.com>
…gation, logging

Agent-Logs-Url: https://github.com/nashaofu/shell360/sessions/69a21fcc-f455-4e5e-86ae-e791263e7329

Co-authored-by: nashaofu <19303058+nashaofu@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot May 6, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants