You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This removes the sidebar search to enable search-as-you-type functionality in the navbar search.
The functionality needs the newest release of napari-sphinx-theme so if you build locally make sure to use pixi update.
😁
I want to follow-this up to potentially improve the visual of the search bar
Oh wow, this made me notice that the search/mag glass in the nav bar doesn't work on live napari.org ?!?
Can you check again? It should pop-up a modal on the homepage, on the other pages its sneakier though, focus snaps to the sidebar search (which is part of the motivation of this change)
Themeing follow-up napari/napari-sphinx-theme#223
If we like this, I will make a napari/docs follow-up to use the search-field for the navbar rather than the search-symbol as it is now (so its a field when screen is wide and just a symbol when narrow)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
documentationImprovements or additions to documentation
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Closes #979
Description
This removes the sidebar search to enable search-as-you-type functionality in the navbar search.
The functionality needs the newest release of napari-sphinx-theme so if you build locally make sure to use
pixi update.😁
I want to follow-this up to potentially improve the visual of the search bar