Skip to content

Better types for custom elements - #148

Open
Atulin wants to merge 2 commits into
nanojsx:masterfrom
Atulin:master
Open

Better types for custom elements#148
Atulin wants to merge 2 commits into
nanojsx:masterfrom
Atulin:master

Conversation

@Atulin

@Atulin Atulin commented Apr 12, 2025

Copy link
Copy Markdown

I decided to add some more types to the custom element registration function, mainly around ensuring that the prop name array passed to it adheres to the actual props passed to the component.

Before commit, I ran denoify, as well as prettier and eslint.

Ideally, I'd like to eradicate any from the entire codebase, but... small steps. And maybe a fork proper, if proper typings are not something the project maintanier desires.

@yandeu

yandeu commented Apr 21, 2025

Copy link
Copy Markdown
Member

Thanks for your PR. Some check have failed. I will have a look once I find a litte time.

@yandeu yandeu added the enhancement New feature or request label Apr 21, 2025
@yandeu

yandeu commented Aug 11, 2025

Copy link
Copy Markdown
Member

I'm very interested in better types, but I think it is difficult because of the flexibility of nano-jsx.

Unfortunately, the tests fail :(

There is no need for running denoify before commiting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants