WIP: feat time domain solar wind covariance#1966
WIP: feat time domain solar wind covariance#1966jeremy-baier wants to merge 20 commits intonanograv:masterfrom
Conversation
…uble; add tests for time domain solar wind; add tests for noise design matrix precision
…are not changing; add tests
scottransom
left a comment
scottransom
left a comment
There was a problem hiding this comment.
There's a lot in here and it is beyond me to go through carefully line-by-line! We definitely need to make sure that there are some test cases and/or examples available that provide results that you believe are correct.
| ecorrs = self.get_ecorrs() | ||
| if nweights is None: | ||
| ts = (toas.table["tdbld"].quantity * u.day).to(u.s).value | ||
| ts = get_tdb_seconds(toas.table) |
There was a problem hiding this comment.
Any reason that isn't just tbl as in the other calls?
| self.TDSWLOGSIG.value | ||
| except AttributeError: | ||
| log.warning( | ||
| "TDSWLOGSIG is not set, using default value of -6.0 s for TimeDomainRidgeSWNoise" |
There was a problem hiding this comment.
The "-6.0 s" might be confusing in that description. Maybe say something like default value of -6.0 (i.e. 1 us)?
| return project_basis_covariance(Fmat, phi) | ||
|
|
||
|
|
||
| class TimeDomainRidgeSWNoise(NoiseComponent): |
There was a problem hiding this comment.
Each of the TimeDomainXXXSWNoise classes seem very similar and therefore have a lot of code replication. Would it be difficult to make a TomeDomainSWNoise class where the kernel was a parameter that would eliminate much of that replication?
There was a problem hiding this comment.
this is a good suggestion. We really should modularize this if possible. I will have to look into this and see about a refactoring. This might take a minute but it would really clean up the code.
|
thanks for the comments, Scott ! I will take a look and see about implementing them. |
2 participants
Needed for NG20.
Major changes
More work should really explore additional caching of various parts of the GLS fit when the noise model is being held constant. This might be sub blocks of the design matrix. Or a refactorization of the GLS implementation.
TODO
Disclosure that I used co-pilot for generating the unit tests as well as some docstrings and type hinting.