fix #326 refresh naming cache on subscribe#330
Merged
KomachiSion merged 1 commit intoJul 6, 2026
Conversation
KomachiSion
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_instances(subscribe=True)returning stale local naming cache when the service was loaded from disk but not subscribed to the server yet.subscribe=trueconfirms subscription and refreshes cache, whilesubscribe=falsequeries the server directly.Test plan
./.venv/bin/python -m unittest test.test_naming_service_cache -v./.venv/bin/python -m unittest test.test_skill_and_prompt test.test_naming_service_cache -v./.venv/bin/python -m compileall v2/nacos/naming test/test_naming_service_cache.pysubscribe=Trueand direct server query works forsubscribe=FalseCloses #326