Name the posted bit in terminate() - #115
Merged
Merged
Conversation
terminate() tested the ECB posted bit as a raw 0x40000000U, twice, while the wait loop in main() a few hundred lines up spells it ECB_POSTED_BIT. Same bit, same struct field, two vocabularies -- and the raw one is the harder to grep for when the question is "where do we check whether the socket thread has ended". Generated assembler is byte identical before and after; clibecb.h defines the macro as exactly that constant. Noted as leftover work in #112.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first of the two leftovers noted at the end of #112. The second turned out
not to exist — see below.
The change
terminate()tested the ECB posted bit as a raw0x40000000U, twice, while thewait loop in
main()a few hundred lines up spells itECB_POSTED_BIT. Samebit, same struct field, two vocabularies — and the raw one is the harder to grep
for when the question is "where do we check whether the socket thread has ended".
Generated assembler is byte identical before and after (
cc370 -O1 -S,cmp);clibecb.hdefines the macro as exactly that constant.makeclean,make test-host78/78,tools/check-module-data.pyclean.The other leftover was a false alarm
#112 also said "the bare-
__asm__pattern fixed here exists in other FTPDsources — this PR only covers
src/ftpd.c". That is wrong, and worth correctingrather than leaving as a standing to-do.
src/ftpd.cis the only file in the repository containing inline assemblerat all — five
STIMERsites, all of which already carry"0", "1", "14", "15"from #114:Nothing else in
src/,include/orasm/has an__asm__beyond theSETC '&FUNC'name markers. So there is no follow-up owed here.The equivalent sweep in libc370, where the pattern really does recur, is
mvslovers/libc370#134.