Read the SITE SUBMIT jobid via jesircl2() instead of the freed VSFILE - #103
Merged
Conversation
The jobid arrives with the ENDREQ inside jesircls() and the vsclose() in the same call frees the VSFILE carrying it, so the rplrbar read after the close fetched from freed storage -- working only because free() leaves block contents intact. jesircl2() (libc370#118) copies the 8-byte feedback out between the ENDREQ and the close. The handle pointer is dropped immediately: it is freed even when the close reports an error. Fixes #102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102
Same defect and same fix as mvslovers/mvsmf#297: the post-close
rplrbarread fetched the jobid from the freed VSFILE.jesircl2()(libc370#118/#119, in the sysroot) hands it out legally between ENDREQ and close.Built clean against the updated sysroot (
make modules). Not live-verified: no FTPD deploy/restart was done — the running FTPD is the recovery channel for the dev system, so exercising SITE SUBMIT against a new build is left for the next regular FTPD rollout. The mvsMF twin of this change is live-verified (submit returnsJOBnnnnn).