fix: silence the GCC doc build (no texi2pod.pl in this tree) - #98
Merged
Conversation
contrib/ was stripped from the GCC tree in 4077723, texi2pod.pl with it, but gcc's doc: target kept running: configure finds Pod::Man >= 1.10 and sets GENERATED_MANPAGES=generated-manpages, so every doc/{gcc,cpp,gcov}.1 and doc/{gfdl,gpl,fsf-funding}.7 target failed on each clean build -- Can't open perl script ".../contrib/texi2pod.pl": No such file or directory make[1]: [gcc.pod] Error 2 (ignored) pod2man: unable to format gcc.pod make[1]: [doc/gcc.1] Error 1 (ignored) -- and left a 10-byte "timestamp" stub behind. The errors are ignored, so the build still succeeded; it just printed six of these pairs. Nothing installs those pages: install-man ships only man/*.1, generated from this repo's own man/*.pod, and there is no gcc/cpp/gcov binary to document. So turn the consumer off rather than restore the script -- hardcode GENERATED_MANPAGES empty in gcc/Makefile.in. BUILD_INFO gets the same treatment. It is empty today only because this host has no makeinfo; with texinfo installed, configure sets it to "info" and pushes GCC 3.4.6 texinfo through a modern makeinfo for info files we equally do not ship. Hardcoding it makes the build host-independent instead of accidentally quiet. Verified with a fresh out-of-tree build (configure + all-gcc): no texi2pod or pod2man lines, no stub man pages in doc/, cc1 + xgcc build and work (-dumpmachine = cc370, -O1 -S on a trivial TU), cc370/tests/run.sh green. The configure-time "Makeinfo is missing or too old" warning comes from configure's own check and is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every clean
make/make compilerprinted six of these pairs:4077723("strip non-build cruft from the GCC tree") removedcontrib/, and with itcontrib/texi2pod.pl— but not the target that consumes it.configurefindsPod::Man >= 1.10, setsGENERATED_MANPAGES=generated-manpages, anddoc:then walksdoc/{gcc,cpp,gcov}.1+doc/{gfdl,gpl,fsf-funding}.7, failing on each and leaving a 10-bytetimestampstub inbuild/gcc/doc/. The errors are--prefixed, so the build succeeded — it was pure noise.Fix
Hardcode both doc knobs empty in
cc370/gcc/Makefile.ininstead of restoring the script:GENERATED_MANPAGES— nothing installs those six pages.install-manships only$(MAN1), generated from this repo's ownman/*.pod, and there is nogcc/cpp/gcovbinary to document. Restoringtexi2pod.plwould add six texi→pod→man conversions per clean build for files nobody uses.BUILD_INFO— empty today only because the dev host has nomakeinfo. On a host with texinfo installed,configuresets it toinfoand pushes GCC 3.4.6 texinfo through a modernmakeinfofor info files we equally do not ship. Hardcoding makes the build host-independent rather than accidentally quiet.doc:is now justgccbug.Verification
Fresh out-of-tree build (
configure+all-gcc) on a clean tree:texi2pod/pod2manlines in the log, noError … (ignored)build/gcc/doc/stays empty — notimestampstubscc1+xgccbuild;-dumpmachine→cc370;-O1 -Son a trivial TU emits the expectedCOPY PDPTOP/GCCMVS!!prologuecc370/tests/run.sh→ALL CC370 TESTS PASSEDUnaffected and still present: the configure-time warning
*** Makeinfo is missing or too old. *** Info documentation will not be built.— that comes fromconfigure's own check, not from the doc rules.