Stop calling string sorting broken in inventory_report - #4
Merged
Conversation
The README said sorting the category names was "not currently possible" because algorithm.sort on a list<string> returned the list unchanged, and cited muxlang/mux-compiler#390. That shipped in 0.9.0 - sort now orders strings correctly - so the note described a bug as the reason for a choice that stands on its own. Rewritten as the actual reason: first-seen order reports categories in the order the source data introduces them, which is usually what someone reading that data expects, and it needs no second pass.
|
| Filename | Overview |
|---|---|
| examples/inventory_report/README.md | Replaces an obsolete compiler limitation with an accurate explanation of the example’s deliberate first-seen ordering; no actionable issues found. |
Reviews (1): Last reviewed commit: "Stop calling string sorting broken in in..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while sweeping for stale references to issues this release closed.
The README said sorting the category names was "not currently possible" because
algorithm.sorton alist<string>returned the list unchanged, citing muxlang/mux-compiler#390. That shipped in 0.9.0:So the example was justifying its design with a bug that no longer exists - and the design does not need that justification. Rewritten as the real reason: first-seen order reports categories in the order the source data introduces them, which is usually what someone reading that data expects, and it needs no second pass.
Verified
algorithm.sorton strings against the compiler before changing the claim. Example still passes.