Update errors in multisig contracts#3
Open
rvem wants to merge 1 commit into
Open
Conversation
Currently all contracts use `PUSH unit (); FAILWITH` in case of different failures. It would be more convenient to fail with something more specific. Here we propose failures with human-readable strings.
gromakovsky
approved these changes
Oct 1, 2019
|
Since at least one of these contracts seems to be used by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, all contracts use
PUSH unit (); FAILWITHin case ofdifferent failures. It would be more convenient to fail with something
more specific. Here we propose failures with human-readable strings.