⚡ Avoid full lint builds and honor disabled IPO - #2470
Merged
Conversation
Generate the headers needed by clang-tidy instead of building the full project. Adopt the targeted shared workflow and disable compiler-cache checks for header-only preparation. Recompute effective IPO on each configure so turning ENABLE_IPO off clears stale optimization settings. Cover the on/off transition in a small CMake regression test. Assisted-by: GPT-6 via Codex
burgholzer
added
continuous integration
Use the merged workflow from workflows #463. Assisted-by: GPT-6 via Codex
Keep the IPO setting fix and remove its standalone CMake test. Assisted-by: GPT-6 via Codex
burgholzer
commented
Sep 8, 2026
burgholzer
left a comment
burgholzer
left a comment
Member
Author
There was a problem hiding this comment.
This should yield quite substantial improvements to local dev cycles as well as CI turnaround times for linting.
burgholzer
enabled auto-merge (squash)
September 8, 2026 13:04
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
C++ lint currently builds and links the full project before analysis. Add
mqt-core-lint-headersto prepare the dialect, interface, and pass headers needed by clang-tidy, and use it in local Nox and CI. Disable compiler-cache checks for this header-only CI preparation. The target is empty when MLIR is disabled.Also fix
ENABLE_IPO=OFFleaving cached IPO enabled after an earlier ON configuration. Compute the effective setting on every configure.The reusable lint workflow is pinned to the merged commit from workflows #463.
Validation: required
uvx nox -s lintpasses; the actualuvx nox -s cpp-lintpreparation succeeds in a fresh build directory. All 297 project translation units preprocess with the generated headers, and compiler pipeline, DDSIM device, compiler tests, and DD binding translation units pass syntax checks. Header preparation also succeeds without MLIR. No C++ source changed; the Nox linter therefore has no changed C++ files to analyze. Hosted CI remains pending.GPT-6 via Codex implemented and validated this change at the maintainer's request.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).