🐛 Preserve QDMI provider lifetime and target metadata - #2454
Merged
Conversation
Keep loaded providers shared across path aliases and fresh sessions. Harden session setup and C entry-point errors, retain explicit Qiskit placements, convert durations to seconds, and validate SC names and topology lookups. Consolidate Python binding tests and isolate registry mutations. Assisted-by: GPT-6 via Codex
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Move platform-specific lambdas outside EXPECT_EXIT arguments so MSVC does not encounter preprocessor directives inside a function-like macro. Assisted-by: GPT-6 via Codex
Member
Author
|
Another batch of nice improvements. Some of them pulled out of the 4.1 PR stack already, which should help to trim these down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Fix QDMI metadata and provider ownership defects found in the follow-up audit:
Consolidate redundant Python semantic tests while retaining binding coverage, and isolate registration tests so invalid providers cannot contaminate later enumeration.
Includes independent lifetime/session fixes from #2230 and allocation/enum fixes from #2229. The remaining driver redesign stays deferred. No independent extraction from #2231 was justified because its shared-client and staging changes depend on that redesign. This PR has no dependency on those PRs.
Validation: 465 native QDMI tests passed, one existing SC test skipped; 10 staging/configuration checks passed; 468 serial Python QDMI/plugin tests passed. Repository lint passed. Committed-diff C++ lint checked all six changed C++ source files with zero findings. Hosted CI is pending. These changes concern unreleased v4 functionality, so no standalone changelog or upgrade entry is required.
Codex assisted with the audit, implementation, tests, and this description. Human review remains pending.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).