Skip to content

✨ Add repeat-until-success benchmark - #2410

Draft
denialhaag wants to merge 3 commits into
codex/add-controlled-multiplication-modulo-nfrom
codex/add-repeat-until-success
Draft

✨ Add repeat-until-success benchmark#2410
denialhaag wants to merge 3 commits into
codex/add-controlled-multiplication-modulo-nfrom
codex/add-repeat-until-success

Conversation

@denialhaag

@denialhaag denialhaag commented Sep 5, 2026

Copy link
Copy Markdown
Member

Description

🤖 AI text below 🤖

Add a fixed repeat-until-success benchmark based on Figure 8 of Paetznick and Svore's paper: https://arxiv.org/abs/1311.1074v2. Expose the benchmark through the typed C++, JSON and command-line, Python, and MLIR generation interfaces.

Generate the exact two-qubit post-test retry loop, including ancilla cleanup after failed attempts and the phase-sensitive readout after success. Add the analytic output distribution, strict JSON handling, circuit-structure and jeff round-trip tests, seeded execution coverage, and documentation.

This PR is stacked on #2409.

AI notice

This PR and its contents were created with the assistance of GPT-5.6 Sol via Codex.

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
  • Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
  • I have disclosed AI assistance in the PR description.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

@denialhaag denialhaag added feature New feature or request c++ Anything related to C++ code python Anything related to Python code MLIR Anything related to MLIR labels Sep 5, 2026
@denialhaag denialhaag self-assigned this Sep 5, 2026
@denialhaag
denialhaag force-pushed the codex/add-repeat-until-success branch from 6b0f0d7 to 06dbd77 Compare September 5, 2026 18:01
@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.95918% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/bench/JSON.cpp 92.3% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@denialhaag
denialhaag force-pushed the codex/add-repeat-until-success branch from 06dbd77 to 7eb49b4 Compare September 5, 2026 23:09
@denialhaag denialhaag added this to the v4.0.0 - IEEE Quantum Week milestone Sep 6, 2026
@denialhaag
denialhaag force-pushed the codex/add-repeat-until-success branch 2 times, most recently from 2e5a46c to 2626c29 Compare September 8, 2026 14:08
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Move the Python coverage into its family-specific test module. Run
execution sampling in the native MLIR test and rely on the shared
registry test for jeff serialization.

Use math markup in the Python binding documentation and align the plan
with the shared checks.

Assisted-by: GPT-5.6 Sol via Codex
@denialhaag
denialhaag force-pushed the codex/add-repeat-until-success branch from 2626c29 to 9ae51f5 Compare September 8, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Anything related to C++ code feature New feature or request MLIR Anything related to MLIR python Anything related to Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant