Fix max_slow_speed setting saving to min_gap#4
Open
pantic14 wants to merge 1 commit into
Open
Conversation
…he max slow speed dropdown assigned the value to settings.min_gap instead of settings.max_slow_speed, so the slow speed threshold was never saved and changing it silently overwrote the group gap setting. Same copy-pasted handler fixed in all three scripts.
There was a problem hiding this comment.
Pull request overview
Fixes a settings persistence bug where the max_slow_speed dropdown change handler was incorrectly saving its value into settings.min_gap, causing the slow-speed threshold to never persist and potentially overwriting the group-gap setting.
Changes:
- Update the
max_slow_speedchange handler to write tosettings.max_slow_speed(instead ofsettings.min_gap) inapp.js. - Apply the same fix to the corresponding handlers in
app-2025.jsandapp-by-distance.js.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app.js | Corrects max_slow_speed dropdown persistence by saving to the proper settings key. |
| app-by-distance.js | Mirrors the same handler fix for the distance-based variant. |
| app-2025.js | Mirrors the same handler fix for the 2025 variant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change handler for the max slow speed dropdown assigns its value to settings.min_gap instead of settings.max_slow_speed. Two consequences: the slow-speed threshold is never actually saved (it always stays at the default), and changing that dropdown silently overwrites the saved group-gap setting.
Same copy-pasted handler fixed in app.js, app-2025.js and app-by-distance.js.