Auto-focus answer input in typing practice mode - #398
Merged
Conversation
The answer input is now focused whenever it appears or a new card loads, so the user can start typing immediately without clicking. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GQQE5BSowYj6kkiSygSWhv
ReviewSmall, well-scoped change. The auto-focus behavior is implemented idiomatically using Angular signals ( Code quality
Minor observations (non-blocking)
Bugs / security / performanceNothing found. No backend changes, no risk of null-deref ( Overall: looks good to merge once the accessibility trade-off in point 2 is a conscious decision rather than an oversight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Auto-focus the answer input field when each card is displayed in typing practice mode, eliminating the need for users to click before typing their answer.
Changes
viewChildreference to the answer input field inLearnSimpleCardComponent#answerInputImplementation Details
The focus behavior is triggered by an effect that watches for card changes. When a new card is displayed (detected by accessing
this.card()?.value()), the effect automatically callsfocus()on the answer input element. This provides a seamless typing experience where users can immediately start typing without an extra click.https://claude.ai/code/session_01GQQE5BSowYj6kkiSygSWhv