Skip to content
This repository was archived by the owner on Aug 31, 2025. It is now read-only.

retry to enter raw repl when listing fs#2378

Closed
gschaden wants to merge 1 commit into
mu-editor:masterfrom
gschaden:master
Closed

retry to enter raw repl when listing fs#2378
gschaden wants to merge 1 commit into
mu-editor:masterfrom
gschaden:master

Conversation

@gschaden

Copy link
Copy Markdown

Sometimes the repl response is not detected on my esp32.
Might also solve #2360

@ntoll

ntoll commented Jan 9, 2023

Copy link
Copy Markdown
Member

👋 @gschaden could you please make these changes to the upstream module https://github.com/ntoll/microfs ..? Thank you..!

Comment thread mu/contrib/microfs.py
serial.write(b"\r\x01")
flush_to_msg(serial, raw_repl_msg)
break
except:

Check notice

Code scanning / CodeQL

Except block handles 'BaseException'

Except block directly handles BaseException.
Comment thread mu/contrib/microfs.py
serial.write(b"\r\x01")
flush_to_msg(serial, raw_repl_msg)
break
except:

Check notice

Code scanning / CodeQL

Empty except

'except' clause does nothing but pass and there is no explanatory comment.
@gschaden

gschaden commented Jan 10, 2023

Copy link
Copy Markdown
Author

Sent to upstream request https://github.com/ntoll/microfs/pull/40

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants