feat: default leg kite sized for 1:250,000 print (18.5×20mm + 1cm triangle)#1099
Closed
msupino wants to merge 5 commits into
Closed
feat: default leg kite sized for 1:250,000 print (18.5×20mm + 1cm triangle)#1099msupino wants to merge 5 commits into
msupino wants to merge 5 commits into
Conversation
…angle) Kite px are anchored at z12 (legZoomScale = 2^(z-12)) → a fixed ground footprint → a fixed paper size at the app's 1:250,000 page-frame scale (1 mm = 250 m; mpp(z12) ≈ 32.37 m/px ⇒ 1 mm ≈ 7.72 px). Defaults now: square 18.5 mm wide (cell×2 = 143 px) × 20 mm tall (154.5 px), triangle 10 mm long (77 px) — up from ~6 mm. Text/border unchanged (still legible, verified in preview). The live tuning gist was updated to match; this is the version-controlled fallback. Guard test asserts the mm.
# Conflicts: # docs/index.html
Contributor
🚀 Preview deployed
Commit: |
The 0.35 floor in legZoomScale() keeps kites clickable when zoomed out on screen, but it also inflated the exported kite: a route framed on A4 at a low zoom (z9-z10, common for long routes) printed the square at 26-56 mm instead of the intended 18.5x20 mm. Export re-runs drawLegs(), so skip the floor when NavAid.exporting is set -> the kite renders at its true z12-anchored 1:250,000 paper size (18.5x20 mm + 10 mm triangle) at any framing zoom. On-screen behaviour (and hit-testing, which never runs during export) is unchanged.
Owner
Author
|
Reverting kite-size approach — current behaviour preferred. Closing per request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The leg kite's default size now matches a real nav-log kite at the app's 1:250,000 page-frame scale.
Kite px are anchored at z12 (
legZoomScale = 2^(z-12)), giving a fixed ground footprint → a fixed paper size at 1:250,000 (1 mm = 250 m; mpp(z12) ≈ 32.37 m/px ⇒ 1 mm ≈ 7.72 px). Defaults:legKiteCellWidthPx71.5 ×2 = 143 px) × 20 mm tall (legKiteHeightPx154.5 px)legKiteTriangleLenPx77 px)Up from ~6 mm. Text/border unchanged — still legible at the new size (verified in preview). Assumed square = 18.5 wide × 20 tall; trivially swappable if you meant the reverse.
Note: the live tuning gist (production override) was updated to the same values so the map changes immediately; this PR is the version-controlled fallback/default. Guard test asserts the printed mm at z12.