Skip to content

src/main.sh: Add --experimental-features and --extra-experimental-features support - #34

Open
ShamrockLee wants to merge 1 commit into
msteen:masterfrom
ShamrockLee:experimental-features
Open

src/main.sh: Add --experimental-features and --extra-experimental-features support#34
ShamrockLee wants to merge 1 commit into
msteen:masterfrom
ShamrockLee:experimental-features

Conversation

@ShamrockLee

@ShamrockLee ShamrockLee commented Feb 10, 2022

Copy link
Copy Markdown
  • Default to using --extra-experimental-features
    instead of --experimental-features
    to show respect to the environment configuration.

  • Add flags --extra-experimental-features and --experimental-features
    to allow manual specification to the experimental-features setting
    (e.g. use builtins.getFlake when not globally enabled).

Fixes #35

@ShamrockLee
ShamrockLee marked this pull request as draft February 10, 2022 04:40
@ShamrockLee ShamrockLee changed the title src/main.sh: Add --experimental-features and --extra-experimental-features support [WIP] src/main.sh: Add --experimental-features and --extra-experimental-features support Feb 10, 2022
@ShamrockLee
ShamrockLee force-pushed the experimental-features branch from 00ed107 to c8192ed Compare February 10, 2022 05:31
@ShamrockLee ShamrockLee changed the title [WIP] src/main.sh: Add --experimental-features and --extra-experimental-features support src/main.sh: Add --experimental-features and --extra-experimental-features support Feb 10, 2022
@ShamrockLee
ShamrockLee marked this pull request as ready for review February 10, 2022 05:37
@ShamrockLee
ShamrockLee force-pushed the experimental-features branch from c8192ed to 9da16d6 Compare February 12, 2022 17:48
@Kranzes

Kranzes commented Mar 4, 2022

Copy link
Copy Markdown

@msteen Can you please merge this and tag a new release?

@ShamrockLee ShamrockLee mentioned this pull request Apr 20, 2022
@ShamrockLee
ShamrockLee force-pushed the experimental-features branch from 9da16d6 to 571ec2d Compare August 3, 2022 01:58
@ShamrockLee

Copy link
Copy Markdown
Author

Describe the changes inside the CHANGELOG.md for version 0.4.2.

@ShamrockLee

Copy link
Copy Markdown
Author

@msteen Could you help take a look?

*   Default to using --extra-experimental-features
    instead of --experimental-features
    to show respect to the environment configuration.

*   Add flags --extra-experimental-features and --experimental-features
    to allow manual specification to the experimental-features setting
    (e.g. use `builtins.getFlake` when not globally enabled).
@ShamrockLee
ShamrockLee force-pushed the experimental-features branch from 571ec2d to c5744ef Compare August 3, 2022 02:08
@ShamrockLee

Copy link
Copy Markdown
Author

I accidentally base the CHANGELOG.md work on a non-relevant commit. Just solve the problem.

@jakubgs

jakubgs commented Nov 8, 2023

Copy link
Copy Markdown

Any news on this? I'd love to be able to generate a new vendor SHA for packages built with buildGoModule in a flake.nix.

m15a added a commit to m15a/flake-awesome-neovim-plugins that referenced this pull request May 10, 2024
Hopefully fixes: #130

Even though nix-installer-action enables flakes by default,
it is overrided by nix-prefetch since it sets `--experimental-features`.

See msteen/nix-prefetch#34
@eclairevoyant

Copy link
Copy Markdown

This repo hasn't seen activity in 3 years, it's time for a fork.

@ShamrockLee

Copy link
Copy Markdown
Author

@eclairevoyant Considering that this project is mission-critical to Nixpkgs, it sounds reasonable to either merge it into Nixpkgs or move it under the nix-community organization. How should we proceed with the forking?

I opened an issue about this two years ago (#40). We could discuss it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add flake support

4 participants