Add Russian localization and i18n foundation#133
Open
DrMaks22 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Localizableresources and anL10nfacade.Brewfileas a format name.enrichment.<locale>partial overlays replace user-facing prose and add locale-specificsearch_termswithout translating package identifiers,similar, or technical tags.wget,curl,git,node,python@3.13,postgresql@14,visual-studio-code,firefox,google-chrome,vlc,docker,slack,neovim,ripgrep,openssl@3,ffmpeg,redis,kubernetes-cli).Future Localization Path
tools/enrich/README.mdnow documents the intended workflow for additional languages:src/lib/i18n, language selector, nativeLocalizableresources, native locale routing).native/Sources/BrewBrowserKit/Resources/enrichment.<locale>.json.src-tauri/data/enrichment.<locale>.json.gzwith deterministic gzip settings.friendly_name,summary,use_cases; add searchable natural-language aliases insearch_terms; do not translatesimilar,tags, package tokens, commands, flags, URLs, APIs, or product names.Notes
RecentChangesparsing and existing tests keep working; rendered labels and notifications are localized throughL10n.Validation
npm run checkpasses: 0 errors, 0 warnings.npm testpasses: 4 files, 49 tests.cargo fmt --manifest-path src-tauri/Cargo.toml --checkpasses.cargo test --manifest-path src-tauri/Cargo.tomlpasses: 671 passed, 6 ignored integration tests.cd native && swift buildpasses.cd native && swift testpasses: 173 tests.git diff --checkpasses..stringsparity passes for both SwiftPM targets: 830 English keys / 830 Russian keys, no missing/extra Russian keys..xcstringscoverage passes for both SwiftPM targets: 830 keys, no missing Russian localizations and noneeds_reviewRussian entries.ru-localizationdocs structure check passes fortools/enrich/README.md.ru-localizationquality lint passes forenrichment.ru.jsonwith 0 findings. The broader TS/native string-file lint still reports known false positives because it treats English source keys (for example"Open Settings") as visible Russian text; remaining items were manually reviewed.ruPlural, and English Activity labels remain stable internal event identifiers with localized render output.Visual QA Limitations