iOS fractional crop coordinates cause an incorrect byte offset#97
Open
dodokw wants to merge 1 commit into
Open
iOS fractional crop coordinates cause an incorrect byte offset#97dodokw wants to merge 1 commit into
dodokw wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mrousavy
Summary
Fix incorrect iOS cropping when the calculated crop rectangle contains fractional values.
cropYfrom becoming an unintended in-row byte offset.Fixes #
Root cause
When no explicit crop is provided, the automatic center-crop calculation can produce fractional coordinates.
For example, resizing a
640x480frame to576x320calculates approximately:cropHeight = 355.555cropY = 62.222Previously, iOS kept these values as
CGFloatand converted only the final byte-offset expression tosize_t: