feat: PR4b — binary decoder, fallback migration, logical clear#9
Open
mrmidi wants to merge 1 commit into
Open
Conversation
mrmidi
force-pushed
the
pr4b/binary-decoder
branch
4 times, most recently
from
July 22, 2026 04:28
488aec3 to
dbb683d
Compare
TunnelDiagnosticsDecoder (FptnVPN/Services/): - Injectable paths, clocks, ticksToSeconds (mach_timebase_info) - Per-process wall-time anchors from processStarted events - Unknown-safe: preserves raw event codes, timestamp nil without anchor - FptnReadStatus: OK/FileNotFound/InvalidHeader/Empty/IoError - Full ring header validation: magic, schema, geometry, CRC, file size - errno-based status (ENOENT vs IoError) - Null-safe output_count check - Failure report filtered by processToken + sessionToken - Logical clear watermark (hide events at/below watermark) VPNService migration: - evaluateFallbackDecision uses binary snapshot - Controlled-stop check first (trust window), then freshness recheck - Failure report uses makeFailureReport (session-filtered) LogsViewModel migration: - Export uses binary decoder - Clear writes logical watermark instead of deleting binary files Event value payloads: - transportDisconnected: value0=disconnectCode, value1=stopOrigin, value2=activeOps, flags[0]=wasConnected - reconnectScheduled: value0=attempt, value1=delaySeconds, flags[0]=pathSatisfied - memoryWarning/Critical: value0=footprint, value1=resident, value2=peak - Memory recording separated from OSLog throttle (level-change tracking) - physicalFootprintPeakBytes captured under diagnosticsLock Schema ABI: - fptn_diagnostics_schema_version, capacity, record_size, ring_file_size - FptnReadStatus enum in public C header Remaining: FptnShared 0.3.0 integration (after PR4a merge/tag) Tests: 27/27 passed. 8 files, +500/-65.
mrmidi
force-pushed
the
pr4b/binary-decoder
branch
from
July 22, 2026 04:53
dbb683d to
ef9d270
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR4b — Binary Decoder, Fallback Migration, Logical Clear
Base:
pr3a/signposts· Head:dbb683d· 8 files, +511/-65TunnelDiagnosticsDecoder
Injectable, unknown-safe app-side decoder:
mach_timebase_infotick→seconds conversion (no hardcoded 1ns assumption)processStartedeventstimestamp == nilwhen no matching process anchorFptnReadStatus: OK / FileNotFound / InvalidHeader / Empty / IoErrorerrno-based classification (ENOENT vs IoError)output_countcheckprocessToken+sessionTokenVPNService migration
evaluateFallbackDecision→ binary lifecycle snapshotmakeFailureReport()(session-filtered)LogsViewModel migration
Event value payloads
transportDisconnectedreconnectScheduledmemoryWarning/CriticalMemory recording separated from OSLog throttle (level-change tracking). Peak captured under
diagnosticsLock.Schema ABI
fptn_diagnostics_schema_version,fptn_flight_recorder_capacity,fptn_flight_recorder_record_size,fptn_flight_ring_file_sizeRemaining
0.3.0integration (after PR4a merge/tag)Verification
Stack