Fix paper module compatibility for Paper API 26.2#211
Open
dubsector wants to merge 8 commits into
Open
Conversation
- Bump paper-api dependency to 26.2.build.35-alpha - Replace removed com.destroystokyo.paper.PaperConfig detection with io.papermc.paper.configuration.GlobalConfiguration, which is present in all modern Paper builds
- Fix PlaceholderAPI repo URL (moved to /releases/) and bump to 2.12.2 - Bump SuperVanish to 6.2.19 (6.2.6-4 no longer resolves via jitpack) - Pin all actions to commit hashes, add permissions blocks, remove cache: maven (cache-poisoning fix), add persist-credentials: false - Add zizmor workflow for ongoing security scanning of workflow files
PlaceholderAPI 2.12.2 no longer transitively provides it
3.5.0 uses ASM that cannot process Java 25 class files (version 69)
maven-shade-plugin 3.6.0 bundles ASM 9.7.1 which only handles up to Java 23. Java 25 (class version 69) requires ASM 9.8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paper-apidependency inpaper/pom.xmlfrom1.21.11-R0.1-SNAPSHOTto26.2.build.35-alphacom.destroystokyo.paper.PaperConfigruntime detection withio.papermc.paper.configuration.GlobalConfiguration(the legacycom.destroystokyo.paperpackages are gone in Paper 26.x)/releases/) and bump to2.12.26.2.19(6.2.6-4no longer resolves via jitpack)org.jetbrains:annotationsas an explicit dependency (no longer transitively provided by PlaceholderAPI 2.12.2)maven-shade-pluginand bump to3.6.0to support Java 25 class files required by Paper 26.2Note on target branch
The contributing guide mentions PRing against a
developbranch, but nodevelopbranch exists in the repo (see #209). With no alternative, I've targetedmasterdirectly — it produced a clean diff of only the files actually changed, whereas targeting5.5.2-releasecaused a misleading +3,449/-3,194 diff due to branch divergence.Test plan
ADVANCE_TIMEgamerule integration active — confirmed via/sleepmost debugshowing correct calculations