Skip to content

Remove arrayref dependency - #246

Merged
saschanaz merged 2 commits into
mozilla:mainfrom
ajtribick:remove-arrayref
Aug 22, 2026
Merged

Remove arrayref dependency#246
saschanaz merged 2 commits into
mozilla:mainfrom
ajtribick:remove-arrayref

Conversation

@ajtribick

Copy link
Copy Markdown
Contributor

Replace arrayref dependency with first_chunk (stable since Rust 1.77)

@saschanaz saschanaz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saschanaz

Copy link
Copy Markdown
Collaborator

MSRV should be updated...

@ajtribick

Copy link
Copy Markdown
Contributor Author

Ok, hopefully 1.85 works since that was when the 2024 edition was stabilised.
Re-ran fmt and fixed the clippy warnings.

@saschanaz

Copy link
Copy Markdown
Collaborator

Err no, I think MSRV update should be a separate PR. Can you split into another PR?

@saschanaz

Copy link
Copy Markdown
Collaborator

And given Firefox MSRV is 1.90, I think it's ok to jump to 1.90.

@saschanaz
saschanaz enabled auto-merge (squash) August 22, 2026 14:37
@saschanaz
saschanaz merged commit bb9ab34 into mozilla:main Aug 22, 2026
16 checks passed
@ajtribick
ajtribick deleted the remove-arrayref branch August 22, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants