Skip to content

Do not re-sort the history of metric definitions - it's already ordered #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
badboy merged 1 commit into from
Jul 22, 2026
Merged

Do not re-sort the history of metric definitions - it's already ordered #2337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 10 additions & 28 deletions etl/glean.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,23 +94,17 @@ def _update_all_pings(self, pings: List[str]):

def _set_definition(self, full_defn: dict):
# sort from latest to earliest
self.definition_history = list(
sorted(
full_defn[self.HISTORY_KEY],
key=lambda x: datetime.fromisoformat(x["dates"]["last"]),
reverse=True,
)
)
self.definition_history = list(full_defn[self.HISTORY_KEY])

# The canonical definition for up-to-date schemas
self.definition = self.definition_history[0]
self.definition = self.definition_history[-1]
self.definition["name"] = full_defn[self.NAME_KEY]
self.definition["origin"] = full_defn[self.ORIGIN_KEY]
self.definition["in_source"] = full_defn[self.IN_SOURCE_KEY]
self.definition["sampling_info"] = full_defn.get(self.SAMPLING_INFO_KEY)

# first seen is the earliest date in the history
self.definition["date_first_seen"] = self.definition_history[-1]["dates"]["first"]
self.definition["date_first_seen"] = self.definition_history[0]["dates"]["first"]

def _set_dates(self, definition: dict):
vals = [datetime.fromisoformat(d["dates"]["first"]) for d in definition[self.HISTORY_KEY]]
Expand Down Expand Up @@ -138,19 +132,13 @@ def __init__(self, identifier: str, definition: dict):
self.tags = self.definition["metadata"].get("tags", [])

def _set_definition(self, full_defn: dict):
self.definition_history = list(
sorted(
full_defn[self.HISTORY_KEY],
key=lambda x: datetime.fromisoformat(x["dates"]["last"]),
reverse=True,
)
)
self.definition_history = list(full_defn[self.HISTORY_KEY])

# The canonical definition for up-to-date schemas
self.definition = self.definition_history[0]
self.definition = self.definition_history[-1]
self.definition["name"] = full_defn[self.NAME_KEY]
self.definition["origin"] = full_defn[self.ORIGIN_KEY]
self.definition["date_first_seen"] = self.definition_history[-1]["dates"]["first"]
self.definition["date_first_seen"] = self.definition_history[0]["dates"]["first"]
self.definition["in_source"] = full_defn[self.IN_SOURCE_KEY]


Expand All @@ -162,21 +150,15 @@ class GleanTag(GleanObject):
def __init__(self, identifier: str, definition: dict):
self.identifier = identifier
self._set_definition(definition)
self.description = self.definition_history[0].get("description")
self.description = self.definition_history[-1].get("description")

def _set_definition(self, full_defn: dict):
self.definition_history = list(
sorted(
full_defn[self.HISTORY_KEY],
key=lambda x: datetime.fromisoformat(x["dates"]["last"]),
reverse=True,
)
)
self.definition_history = list(full_defn[self.HISTORY_KEY])

# The canonical definition for up-to-date schemas
self.definition = self.definition_history[0]
self.definition = self.definition_history[-1]
self.definition["name"] = full_defn[self.NAME_KEY]
self.definition["date_first_seen"] = self.definition_history[-1]["dates"]["first"]
self.definition["date_first_seen"] = self.definition_history[0]["dates"]["first"]


class GleanApp(object):
Expand Down