Update ctest to 0.5 and cubeb-sys to edition 2021 - #134
Merged
Conversation
padenot
force-pushed
the
ctest-editions-clippy-fix
branch
from
June 9, 2026 16:55
293e012 to
e9bfaf8
Compare
ctest 0.4.11 no longer compiles against current rustc due to an API change in garando_syntax. ctest 0.5 fixes this but requires edition 2021 for macro expansion. Update cubeb-sys to edition 2021 and add crate:: prefixes to all intra-crate imports. Adapt systest/build.rs to the new ctest 0.5 API: type_name → rename_struct_ty, field_name → rename_struct_field, and generate → ctest::generate_test (generate_files alone only writes the test sources without compiling and linking the C side). Suppress clippy lints on ctest-generated code in systest/src/main.rs.
…red backends Under `cargo clippy -- -D warnings`, RUSTC_WORKSPACE_WRAPPER and CLIPPY_ARGS are inherited by the cargo invocation cmake runs to build cubeb-coreaudio-rs/cubeb-pulse-rs, so clippy lints in those vendored trees fail the build. Scrub the wrapper variables so the nested build is a plain cargo build.
kinetiknz
force-pushed
the
ctest-editions-clippy-fix
branch
from
June 10, 2026 09:51
200292b to
631a78e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ctest 0.4.11 no longer compiles against current rustc due to an API change in garando_syntax. ctest 0.5 fixes this but requires edition 2021 for macro expansion.
Update cubeb-sys to edition 2021 and add crate:: prefixes to all intra-crate imports. Adapt systest/build.rs to the renamed ctest 0.5 API (type_name/field_name -> rename_struct_field, generate -> generate_files). Suppress clippy lints on ctest-generated code in
systest/src/main.rs.