Skip to content

Dismiss all stale Github reviews#3382

Open
La0 wants to merge 2 commits into
mozilla:masterfrom
La0:github-never-approves
Open

Dismiss all stale Github reviews#3382
La0 wants to merge 2 commits into
mozilla:masterfrom
La0:github-never-approves

Conversation

@La0
Copy link
Copy Markdown
Collaborator

@La0 La0 commented May 22, 2026

This PR dismisses all previous reviews made by the bot, then only publishes a new review if some issues have been detected.

When no issue is found, nothing is published.

Site note: the current github app cannot load its own user information to identify itself (probably a scope missing), so I had to hardcode the bot's login in order to only dismiss its own reviews.

@La0 La0 requested review from Archaeopteryx and marco-c May 22, 2026 09:24
@La0 La0 self-assigned this May 22, 2026
event=ReviewEvent.RequestChanges,
)
else:
# Simply approve the pull request
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment needs to be updated

Comment on lines +70 to +72
logger.info(
"No publishable issue, no review nor comment published on Github."
)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might still want to add a comment maybe? So people know the review bot is done and it didn't find any issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants