Skip to content

Change perf and telemetry alert inactivity time to 3 days.#2950

Open
gmierz wants to merge 5 commits into
mozilla:masterfrom
gmierz:three-days
Open

Change perf and telemetry alert inactivity time to 3 days.#2950
gmierz wants to merge 5 commits into
mozilla:masterfrom
gmierz:three-days

Conversation

@gmierz

@gmierz gmierz commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This patch changes the inactivity time to 3 days for performance and telemetry alerts.

@gmierz
gmierz marked this pull request as draft July 20, 2026 22:33
@gmierz

gmierz commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Sample from a run I did today showing we're handling the new 3-days and weekend properly:

Subject: [bugbot][autofix] PerfAlert regressions with 3 day(s) of inactivity for the 2026-07-20

Content-Type: text/html; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html lang="en-us">
    <head>
        <meta charset="utf-8">
    </head>
    <body>
        <p>Hi there,</p>
        
        <p>
    The following bug is a performance alert which has had no activity in the last 3 days:
</p>
<table style="border:1px solid black;border-collapse:collapse;" border="1">
    <thead>
        <tr>
            <th>Bug</th>
            <th>Summary</th>
        </tr>
    </thead>
    <tbody>
        <tr bgcolor="#E0E0E0"
            >
            <td>
                <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=2053796">2053796</a>
            </td>
            <td>9.06 - 6.42% damp browser-toolbox.webconsole-ready.DAMP + 1 more (Linux, Windows) regression on Fri July 3 2026</td>
        </tr>
    </tbody>
</table>
        <p>
            Sincerely,
            <br>
            BugBot
        </p>
        <p>
                See the search query on <a href="https://mzl.la/4fpY1AR">Bugzilla</a>.
            </p>
        
        <p>
            See the source / report issues on the <a href="https://github.com/mozilla/bugbot/">GitHub repo</a>
        </p>
    </body>
</html>

@gmierz
gmierz marked this pull request as ready for review July 20, 2026 22:56
marco-c
marco-c reviewed Jul 21, 2026
View reviewed changes
Comment thread bugbot/rules/perfalert_inactive_regression.py Outdated
marco-c
marco-c reviewed Jul 21, 2026
View reviewed changes
Comment thread templates/perfalert_inactive_regression_needinfo.txt

:{{ nickname }}, since you are the author of the regressor, bug {{ extra[bugid]["regressor_id"] }}, which triggered this performance alert, could you please provide a progress update?

If this regression is something that fixes a bug, changes the baseline of the regression metrics, or otherwise will not be fixed, please consider closing it as WONTFIX. [See this documentation for more information on how to handle regressions](https://firefox-source-docs.mozilla.org/testing/perfdocs/perftest-in-a-nutshell.html#help-i-have-a-regression-what-do-i-do).

@marco-c marco-c Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrealted: the docs here are not accessible, they contain screenshots without descriptions

@gmierz gmierz Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on this comment? I can get a bug filed to fix this on the mozilla-central side.

marco-c
marco-c reviewed Jul 21, 2026
View reviewed changes
Comment thread templates/perfalert_inactive_regression_needinfo.txt

If this regression is something that fixes a bug, changes the baseline of the regression metrics, or otherwise will not be fixed, please consider closing it as WONTFIX. [See this documentation for more information on how to handle regressions](https://firefox-source-docs.mozilla.org/testing/perfdocs/perftest-in-a-nutshell.html#help-i-have-a-regression-what-do-i-do).

If it’s unclear when the alert may be resolved, then it’s recommended to file a follow-up bug, and close the alert as INCOMPLETE.

@marco-c marco-c Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only mention the INCOMPLETE case and not the other 4?

@marco-c marco-c Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this is a bit different than the actual definition of INCOMPLETE and how people are using INCOMPLETE in general.
INCOMPLETE usually means there is not enough information to proceed.
Why not let people keep the alert bug open instead?

@gmierz gmierz Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need engineers to come to a resolution for the performance alerts within a reasonable time and not leave them open for an unknown amount of time. Often times, bugs in this situation end up becoming stale and I end up closing them. Having this option lets them close the bug to stop being nagged by the bot, and it gives us more up-to-date information about what performance alerts still may need to be resolved. If developers absolutely want to keep a bug open, they have the option of adding a keyword but we don't want to share that as broadly since it could be misused (they can reach out to performance sheriffs about this if need be).

Regarding the INCOMPLETE status, I think that fits the definition you stated since the developers likely haven't gathered enough information about why the regression happened, about how the regression should be resolved, or the impact of a proposed fix so they can't resolve it at this time. Main reason we're adding it here is because we've had questions about this case so we thought it would be useful to surface the information better in the comment here rather than have devs read the docs. I can include the others, but seems like that'll make the comment a bit bloated.

@gmierz
gmierz requested a review from marco-c July 21, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-c marco-c Awaiting requested review from marco-c

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gmierz @marco-c