Fix mono-to-multichannel mixing when output has discrete channels. - #17
Merged
Merged
Conversation
kinetiknz
force-pushed
the
fix-mono-to-discrete-multichannel-mixing
branch
3 times, most recently
from
March 16, 2026 20:15
abdb882 to
7f6e43d
Compare
padenot
approved these changes
Mar 17, 2026
kinetiknz
force-pushed
the
fix-mono-to-discrete-multichannel-mixing
branch
from
March 17, 2026 18:59
7f6e43d to
81a6738
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect mixing when a mono or stereo source plays to a multichannel output device with a stereo pair plus discrete channels. Previously, mono input would only reach FrontLeft via the diagonal passthrough path; now it correctly falls through to the standard mixing matrix, sending signal to both FrontLeft and FrontRight.
This should fix BMO 1985126.